netdev - Re: [PATCH 7/18] net: dsa: microchip: remove unnecessary set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Sep 2022 14:12:07 +0000
From:   <Arun.Ramadoss@...rochip.com>
To:     <netdev@...r.kernel.org>, <yangyingliang@...wei.com>
CC:     <olteanv@...il.com>, <andrew@...n.ch>,
        <george.mccollister@...il.com>, <vivien.didelot@...il.com>,
        <linus.walleij@...aro.org>, <f.fainelli@...il.com>,
        <hauke@...ke-m.de>, <clement.leger@...tlin.com>,
        <sean.wang@...iatek.com>, <kurt@...utronix.de>,
        <Woojung.Huh@...rochip.com>
Subject: Re: [PATCH 7/18] net: dsa: microchip: remove unnecessary
 set_drvdata()

On Wed, 2022-09-21 at 22:05 +0800, Yang Yingliang wrote:
> Remove unnecessary set_drvdata(NULL) function in ->remove(),
> the driver_data will be set to NULL in device_unbind_cleanup()
> after calling ->remove().

Do we need to remove i2c_set_clientdata(i2c, NULL) in ksz9477_i2c.c or
is it applicable only spi and mdio bus.

> 
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  drivers/net/dsa/microchip/ksz8863_smi.c | 2 --
>  drivers/net/dsa/microchip/ksz_spi.c     | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/drivers/net/dsa/microchip/ksz8863_smi.c
> b/drivers/net/dsa/microchip/ksz8863_smi.c
> index 5247fdfb964d..ddb40838181e 100644
> --- a/drivers/net/dsa/microchip/ksz8863_smi.c
> +++ b/drivers/net/dsa/microchip/ksz8863_smi.c
> @@ -180,8 +180,6 @@ static void ksz8863_smi_remove(struct mdio_device
> *mdiodev)
>  
>  	if (dev)
>  		ksz_switch_remove(dev);
> -
> -	dev_set_drvdata(&mdiodev->dev, NULL);
>  }
>  
>  static void ksz8863_smi_shutdown(struct mdio_device *mdiodev)
> diff --git a/drivers/net/dsa/microchip/ksz_spi.c
> b/drivers/net/dsa/microchip/ksz_spi.c
> index 82e2352f55fa..1b6ab891b986 100644
> --- a/drivers/net/dsa/microchip/ksz_spi.c
> +++ b/drivers/net/dsa/microchip/ksz_spi.c
> @@ -107,8 +107,6 @@ static void ksz_spi_remove(struct spi_device
> *spi)
>  
>  	if (dev)
>  		ksz_switch_remove(dev);
> -
> -	spi_set_drvdata(spi, NULL);
>  }
>  
>  static void ksz_spi_shutdown(struct spi_device *spi)
>