netdev - Re: [PATCH 7/18] net: dsa: microchip: remove unnecessary set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9c7d729-677f-8274-d5b2-339bf4462b46@huawei.com>
Date:   Thu, 22 Sep 2022 22:40:45 +0800
From:   Yang Yingliang <yangyingliang@...wei.com>
To:     <Arun.Ramadoss@...rochip.com>, <netdev@...r.kernel.org>
CC:     <olteanv@...il.com>, <andrew@...n.ch>,
        <george.mccollister@...il.com>, <vivien.didelot@...il.com>,
        <linus.walleij@...aro.org>, <f.fainelli@...il.com>,
        <hauke@...ke-m.de>, <clement.leger@...tlin.com>,
        <sean.wang@...iatek.com>, <kurt@...utronix.de>,
        <Woojung.Huh@...rochip.com>
Subject: Re: [PATCH 7/18] net: dsa: microchip: remove unnecessary
 set_drvdata()

Hi,

On 2022/9/22 22:12, Arun.Ramadoss@...rochip.com wrote:
> On Wed, 2022-09-21 at 22:05 +0800, Yang Yingliang wrote:
>> Remove unnecessary set_drvdata(NULL) function in ->remove(),
>> the driver_data will be set to NULL in device_unbind_cleanup()
>> after calling ->remove().
> Do we need to remove i2c_set_clientdata(i2c, NULL) in ksz9477_i2c.c or
> is it applicable only spi and mdio bus.
Yes, it calls the dev_set_drvdata(), I think it should be remove too.

Thanks,
Yang