netdev - Re: [PATCH net-next 2/2] net: hns3: PF add support setting parameters of congestion control algorithm by devlink param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220922192313.628470a6@kernel.org>
Date:   Thu, 22 Sep 2022 19:23:13 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Guangbin Huang <huangguangbin2@...wei.com>
Cc:     <jiri@...lanox.com>, <moshe@...lanox.com>, <davem@...emloft.net>,
        <idosch@...dia.com>, <edumazet@...gle.com>, <pabeni@...hat.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <lipeng321@...wei.com>, <chenhao418@...wei.com>
Subject: Re: [PATCH net-next 2/2] net: hns3: PF add support setting
 parameters of congestion control algorithm by devlink param

On Fri, 23 Sep 2022 09:38:18 +0800 Guangbin Huang wrote:
> Some new devices support dynamiclly configuring parameters of congestion
> control algorithm, this patch implement it by devlink param.
> 
> Examples of read and set command are as follows:
> 
> $ devlink dev param set pci/0000:35:00.0 name algo_param value \
>   "type@...cn_alp@...f@...tmp@...tkp@...ai@...maxspeed@...g@...al@...cnptime@20" \
>   cmode runtime
> 
> $ devlink dev param show pci/0000:35:00.0 name algo_param
> pci/0000:35:00.0:
>   name algo_param type driver-specific
>     values:
>       cmode runtime value type@...cn_ai@...f@...tkp@...tmp@...alp@...maxspeed@...g@...al@...cnptime@20

Please put your RDMA params to the RDMA subsystem.
It's not what devlink is for. In general 95% of the time devlink params
are not the answer upstream.