netdev - Re: [PATCH net-next v3] ethtool: tunnels: check the return value of nla_nest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Sep 2022 19:28:04 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Li Zhong <floridsleeves@...il.com>
Cc:     netdev@...r.kernel.org, pabeni@...hat.com, edumazet@...gle.com,
        davem@...emloft.net
Subject: Re: [PATCH net-next v3] ethtool: tunnels: check the return value of
 nla_nest_start()

On Wed, 21 Sep 2022 11:17:16 -0700 Li Zhong wrote:
> It will cause null pointer dereference when entry is used
> in nla_nest_end().

No it will not, there is no way for the flow to get to nla_nest_end()
if the skb is full :/

I will fix the commit message myself and apply but I'd like you to not
send more "error checking" patches to networking unless you're sure
that there is indeed a bug.