lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220926092547.4f2a484e@kernel.org> Date: Mon, 26 Sep 2022 09:25:47 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Yinjun Zhang <yinjun.zhang@...igine.com> Cc: Simon Horman <simon.horman@...igine.com>, David Miller <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, oss-drivers <oss-drivers@...igine.com>, Fei Qin <fei.qin@...igine.com> Subject: Re: [PATCH net-next 2/3] nfp: add support for link auto negotiation On Sat, 24 Sep 2022 10:45:30 +0800 Yinjun Zhang wrote: > On Fri, Sep 23, 2022 at 05:24:10PM -0700, Jakub Kicinski wrote: > > > Because the value of sp_indiff depends on the loaded application > > > firmware, please ref to previous commit: > > > 2b88354d37ca ("nfp: check if application firmware is indifferent to port speed") > > > > AFAICT you check if it's flower, you can check that in the main code, > > the app id is just a symbol, right? > > Not only check if it's flower, but also check if it's sp_indiff when > it's not flower by parsing the tlv caps. Seems bogus. The speed independence is a property of the whole FW image, you record it in the pf structure.
Powered by blists - more mailing lists