lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 24 Sep 2022 10:45:30 +0800
From:   Yinjun Zhang <>
To:     Jakub Kicinski <>
Cc:     Simon Horman <>,
        David Miller <>,
        Paolo Abeni <>,
        "" <>,
        oss-drivers <>,
        Fei Qin <>
Subject: Re: [PATCH net-next 2/3] nfp: add support for link auto negotiation

On Fri, Sep 23, 2022 at 05:24:10PM -0700, Jakub Kicinski wrote:
> On Fri, 23 Sep 2022 23:41:57 +0800 Yinjun Zhang wrote:
> > > Why is the sp_indif thing configured at the nfp_main layer, before 
> > > the eth table is read? Doing this inside nfp_net_main seems like 
> > > the wrong layering to me.  
> > 
> > Because the value of sp_indiff depends on the loaded application
> > firmware, please ref to previous commit:
> > 2b88354d37ca ("nfp: check if application firmware is indifferent to port speed")
> AFAICT you check if it's flower, you can check that in the main code,
> the app id is just a symbol, right?

Not only check if it's flower, but also check if it's sp_indiff when
it's not flower by parsing the tlv caps.

Powered by blists - more mailing lists