lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 23 Sep 2022 17:24:10 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Yinjun Zhang <yinjun.zhang@...igine.com> Cc: Simon Horman <simon.horman@...igine.com>, David Miller <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, oss-drivers <oss-drivers@...igine.com>, Fei Qin <fei.qin@...igine.com> Subject: Re: [PATCH net-next 2/3] nfp: add support for link auto negotiation On Fri, 23 Sep 2022 23:41:57 +0800 Yinjun Zhang wrote: > > Why is the sp_indif thing configured at the nfp_main layer, before > > the eth table is read? Doing this inside nfp_net_main seems like > > the wrong layering to me. > > Because the value of sp_indiff depends on the loaded application > firmware, please ref to previous commit: > 2b88354d37ca ("nfp: check if application firmware is indifferent to port speed") AFAICT you check if it's flower, you can check that in the main code, the app id is just a symbol, right?
Powered by blists - more mailing lists