netdev - Re: [PATCH net-next 2/3] nfp: add support for link auto negotiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220923154157.GA13912@nj-rack01-04.nji.corigine.com>
Date:   Fri, 23 Sep 2022 23:41:57 +0800
From:   Yinjun Zhang <yinjun.zhang@...igine.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Simon Horman <simon.horman@...igine.com>,
        David Miller <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        oss-drivers <oss-drivers@...igine.com>,
        Fei Qin <fei.qin@...igine.com>
Subject: Re: [PATCH net-next 2/3] nfp: add support for link auto negotiation

On Fri, Sep 23, 2022 at 06:21:14AM -0700, Jakub Kicinski wrote:
> On Fri, 23 Sep 2022 04:37:58 +0000 Yinjun Zhang wrote:
> > > I can't parse what this is saying but doesn't look good  
> > 
> > I think this comment is clear enough. In previous `
> > nfp_net_pf_cfg_nsp`, hwinfo "sp_indiff" is configured into Management
> > firmware(NSP), and it decides if autoneg is supported or not and
> > updates eth table accordingly. And only `CHANGED` flag is set here so
> > that with some delay driver can get the updated eth table instead of
> > stale info.
> 
> Why is the sp_indif thing configured at the nfp_main layer, before 
> the eth table is read? Doing this inside nfp_net_main seems like 
> the wrong layering to me.

Because the value of sp_indiff depends on the loaded application
firmware, please ref to previous commit:
2b88354d37ca ("nfp: check if application firmware is indifferent to port speed")