netdev - Re: [PATCH net-next 1/3] net: use netdev_unregistering instead of open code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220926104506.559c183d@kernel.org>
Date:   Mon, 26 Sep 2022 10:45:06 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Juhee Kang <claudiajkang@...il.com>
Cc:     Simon Horman <simon.horman@...igine.com>, netdev@...r.kernel.org,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        skhan@...uxfoundation.org
Subject: Re: [PATCH net-next 1/3] net: use netdev_unregistering instead of
 open code

On Mon, 26 Sep 2022 10:04:44 -0700 Jakub Kicinski wrote:
> On Mon, 26 Sep 2022 17:29:39 +0900 Juhee Kang wrote:
> > I will send a patch by applying netdev_registered() helper function by
> > directory.  
> 
> Please hold off doing that. My preference would be to remove
> netdev_unregistering(), this is all low-gain churn.
> IMHO the helpers don't add much to readability and increase 
> the number of random helpers programmer must be aware of.
> Let me check with other netdev maintainers and get back to you.

I got hold of Paolo and he concurred. Let's remove
netdev_unregistering() instead. Thanks!