netdev - Re: [PATCH net-next 1/3] net: use netdev_unregistering instead of open code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK+SQuS-PHYDjRcDf0gmX4ot8pKDoK9G00EzwKkX=o6Jh_fXQA@mail.gmail.com>
Date:   Wed, 28 Sep 2022 23:57:47 +0900
From:   Juhee Kang <claudiajkang@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Simon Horman <simon.horman@...igine.com>, netdev@...r.kernel.org,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        skhan@...uxfoundation.org
Subject: Re: [PATCH net-next 1/3] net: use netdev_unregistering instead of
 open code

Hi Jakub,

On Tue, Sep 27, 2022 at 2:45 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon, 26 Sep 2022 10:04:44 -0700 Jakub Kicinski wrote:
> > On Mon, 26 Sep 2022 17:29:39 +0900 Juhee Kang wrote:
> > > I will send a patch by applying netdev_registered() helper function by
> > > directory.
> >
> > Please hold off doing that. My preference would be to remove
> > netdev_unregistering(), this is all low-gain churn.
> > IMHO the helpers don't add much to readability and increase
> > the number of random helpers programmer must be aware of.
> > Let me check with other netdev maintainers and get back to you.
>
> I got hold of Paolo and he concurred. Let's remove
> netdev_unregistering() instead. Thanks!

Thank you for your review!
I will send the next version which includes removing netdev_unregistering()
as soon as possible.

Best regards,
Juhee