lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <YzFsNXDG0NYsQJLr@Laptop-X1> Date: Mon, 26 Sep 2022 17:09:09 +0800 From: Hangbin Liu <liuhangbin@...il.com> To: Nicolas Dichtel <nicolas.dichtel@...nd.com> Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Ido Schimmel <idosch@...dia.com>, Petr Machata <petrm@...dia.com>, Florent Fourcot <florent.fourcot@...irst.fr>, Nikolay Aleksandrov <razor@...ckwall.org>, Guillaume Nault <gnault@...hat.com> Subject: Re: [PATCHv2 net-next] rtnetlink: Honour NLM_F_ECHO flag in rtnl_{new, set, del}link On Mon, Sep 26, 2022 at 10:37:46AM +0200, Nicolas Dichtel wrote: > > + rtnl_notify(skb, dev_net(dev), pid, RTM_NEWLINK, nlh, GFP_KERNEL); > The fourth argument is the group, not the command. It should be RTNLGRP_LINK > here. But it would be better to pass 0 to avoid multicasting a new / duplicate > notification. Calling functions already multicast one. Thanks for the correcting. I will post a new update. Hangbin
Powered by blists - more mailing lists