lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <TYBPR01MB5341B5F49362BCCF3C168D11D8529@TYBPR01MB5341.jpnprd01.prod.outlook.com> Date: Mon, 26 Sep 2022 09:14:43 +0000 From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, "kishon@...com" <kishon@...com>, "vkoul@...nel.org" <vkoul@...nel.org>, "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "richardcochran@...il.com" <richardcochran@...il.com>, "robh+dt@...nel.org" <robh+dt@...nel.org>, "krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>, "geert+renesas@...der.be" <geert+renesas@...der.be> CC: "andrew@...n.ch" <andrew@...n.ch>, "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org> Subject: RE: [PATCH v2 4/8] dt-bindings: net: renesas: Document Renesas Ethernet Switch > From: Krzysztof Kozlowski, Sent: Monday, September 26, 2022 3:50 PM > > On 26/09/2022 08:10, Yoshihiro Shimoda wrote: > > > I'll add a blank line here. > > > >>> + '#size-cells': > >>> + const: 0 > >>> + > >>> + additionalProperties: false > >> > >> Don't put it between properties. For nested object usually this is > >> before properties: > > > > I'll drop it. > > Don't drop, but instead put it before "properties" for this nested object. Oh, I got it. Thanks! I'll put this before "properties:" like below: ----- ethernet-ports: type: object additionalProperties: false properties: '#address-cells': description: Port number of ETHA (TSNA). const: 1 '#size-cells': const: 0 ----- Best regards, Yoshihiro Shimoda > > > >>> + > >>> + patternProperties: > >>> + "^port@[0-9a-f]+$": > >>> + type: object > >>> + > >> > >> Skip blank line. > > > > I got it. > > > >>> + $ref: "/schemas/net/ethernet-controller.yaml#" > >> > >> No need for quotes. > > > > I'll drop the quotes. > > > >>> + unevaluatedProperties: false > >>> + > >>> + properties: > >>> + reg: > >>> + description: > >>> + Port number of ETHA (TSNA). > >>> + > >>> + phy-handle: > >>> + description: > >>> + Phandle of an Ethernet PHY. > >> > >> Why do you need to mention this property? Isn't it coming from > >> ethernet-controller.yaml? > > > > Indeed. I'll drop the description. > > > >>> + > >>> + phy-mode: > >>> + description: > >>> + This specifies the interface used by the Ethernet PHY. > >>> + enum: > >>> + - mii > >>> + - sgmii > >>> + - usxgmii > >>> + > >>> + phys: > >>> + maxItems: 1 > >>> + description: > >>> + Phandle of an Ethernet SERDES. > >> > >> This is getting confusing. You have now: > >> - phy-handle > >> - phy > >> - phy-device > >> - phys > >> in one schema... although lan966x serdes seems to do the same. :/ > > > > Yes... I found the following documents have "phy" and "phy-handle" by using > > git grep -l -w "phys" `git grep -l phy-handle Documentation/devicetree/bindings/`: > > Documentation/devicetree/bindings/net/cdns,macb.yaml > > Documentation/devicetree/bindings/net/cpsw.txt > > Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml > > Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml > > Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml > > Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml > > Documentation/devicetree/bindings/phy/phy-bindings.txt > > > > And I'm interesting that the phy-bindings.txt said the following: > > ----- > > phys : the phandle for the PHY device (used by the PHY subsystem; not to be > > confused with the Ethernet specific 'phy' and 'phy-handle' properties, > > see Documentation/devicetree/bindings/net/ethernet.txt for these) > > ----- > > Indeed, seems ok. > > > > > Best regards, > Krzysztof
Powered by blists - more mailing lists