netdev - Re: [PATCH net-next v2 07/13] sunhme: Convert FOO((...)) to FOO(...)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b7cc392b-448d-ad40-f915-4b4e4b8c232b@gmail.com>
Date:   Tue, 27 Sep 2022 09:57:50 -0400
From:   Sean Anderson <seanga2@...il.com>
To:     David Laight <David.Laight@...LAB.COM>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     Nick Bowler <nbowler@...conx.ca>,
        Rolf Eike Beer <eike-kernel@...tec.de>,
        Zheyu Ma <zheyuma97@...il.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2 07/13] sunhme: Convert FOO((...)) to FOO(...)

On 9/27/22 03:58, David Laight wrote:
> From: Sean Anderson
>> Sent: 24 September 2022 02:54
>>
>> With the power of variadic macros, double parentheses are unnecessary.
>>
>> Signed-off-by: Sean Anderson <seanga2@...il.com>
>> ---
>>
>> Changes in v2:
>> - sumhme -> sunhme
>>
>>   drivers/net/ethernet/sun/sunhme.c | 272 +++++++++++++++---------------
>>   1 file changed, 136 insertions(+), 136 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
>> index 7d6825c573a2..77a2a192f2ce 100644
>> --- a/drivers/net/ethernet/sun/sunhme.c
>> +++ b/drivers/net/ethernet/sun/sunhme.c
>> @@ -134,17 +134,17 @@ static __inline__ void tx_dump_log(void)
>>   #endif
>>
>>   #ifdef HMEDEBUG
>> -#define HMD(x)  printk x
>> +#define HMD printk
> 
> That probably ought to be:
> 	#define HMD(...) printk(__VA_ARGS__)
> 
> (and followed through all the other patches)

The final macro is

#define hme_debug(fmt, ...) pr_debug("%s: " fmt, __func__, ##__VA_ARGS__)
#define HMD hme_debug

so I think that satisfies your comment.

--Sean