netdev - RE: [PATCH net-next v2 07/13] sunhme: Convert FOO((...)) to FOO(...)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9412f706a4934d218019d74c5f4b74ae@AcuMS.aculab.com>
Date:   Tue, 27 Sep 2022 07:58:35 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Sean Anderson' <seanga2@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Nick Bowler <nbowler@...conx.ca>,
        Rolf Eike Beer <eike-kernel@...tec.de>,
        Zheyu Ma <zheyuma97@...il.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next v2 07/13] sunhme: Convert FOO((...)) to FOO(...)

From: Sean Anderson
> Sent: 24 September 2022 02:54
> 
> With the power of variadic macros, double parentheses are unnecessary.
> 
> Signed-off-by: Sean Anderson <seanga2@...il.com>
> ---
> 
> Changes in v2:
> - sumhme -> sunhme
> 
>  drivers/net/ethernet/sun/sunhme.c | 272 +++++++++++++++---------------
>  1 file changed, 136 insertions(+), 136 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
> index 7d6825c573a2..77a2a192f2ce 100644
> --- a/drivers/net/ethernet/sun/sunhme.c
> +++ b/drivers/net/ethernet/sun/sunhme.c
> @@ -134,17 +134,17 @@ static __inline__ void tx_dump_log(void)
>  #endif
> 
>  #ifdef HMEDEBUG
> -#define HMD(x)  printk x
> +#define HMD printk

That probably ought to be:
	#define HMD(...) printk(__VA_ARGS__)

(and followed through all the other patches)

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)