netdev - Re: [PATCH 3/4] proc: Point /proc/net at /proc/thread-self/net instead of /proc/self/net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Sep 2022 14:31:41 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     David Laight <David.Laight@...lab.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        "Serge E. Hallyn" <serge@...lyn.com>
Subject: Re: [PATCH 3/4] proc: Point /proc/net at /proc/thread-self/net
 instead of /proc/self/net

On Thu, Sep 29, 2022 at 2:27 PM Al Viro <viro@...iv.linux.org.uk> wrote:
>
> Put it another way:
>
> David:
>         when I'm opening /proc/net/whatever, I want its contents to match
>         this thread's netns, not that of some other thread.
> dhclient+apparmor:
>         whatever you get from /proc/net/dev, it would better be at
>         /proc/<pid>/net/dev, no matter which thread you happen to be.

... which actually creates an opening for a truly disgusting solution:

 - when an outsider else opens /proc/<pid>/net, they get the thread leader netns

 - when a thread opens its *own* thread group /proc/<pid>/net, it gets
its own thread netns, not the thread leader one.

Disgusting.

            Linus