netdev - Re: [PATCH ipsec v4] xfrm: replay: Fix ESN wrap around for GSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 30 Sep 2022 06:04:34 +0800
From:   kernel test robot <lkp@...el.com>
To:     Christian Langrock <christian.langrock@...unet.com>,
        Steffen Klassert <steffen.klassert@...unet.com>,
        herbert@...dor.apana.org.au, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org
Subject: Re: [PATCH ipsec v4] xfrm: replay: Fix ESN wrap around for GSO

Hi Christian,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on klassert-ipsec/master]
[also build test ERROR on net-next/master net/master linus/master v6.0-rc7 next-20220929]
[cannot apply to klassert-ipsec-next/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Langrock/xfrm-replay-Fix-ESN-wrap-around-for-GSO/20220929-195233
base:   https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec.git master
config: x86_64-rhel-8.3-func
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/48e26cc03f8bd9712712a13b50c4fbed615beaf2
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Christian-Langrock/xfrm-replay-Fix-ESN-wrap-around-for-GSO/20220929-195233
        git checkout 48e26cc03f8bd9712712a13b50c4fbed615beaf2
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/iommu/ fs/ net/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> net/xfrm/xfrm_replay.c:754:13: error: static declaration of 'xfrm_replay_overflow_check' follows non-static declaration
     754 | static bool xfrm_replay_overflow_check(struct xfrm_state *x, struct sk_buff *skb)
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from net/xfrm/xfrm_replay.c:10:
   include/net/xfrm.h:1752:6: note: previous declaration of 'xfrm_replay_overflow_check' with type 'bool(struct xfrm_state *, struct sk_buff *)' {aka '_Bool(struct xfrm_state *, struct sk_buff *)'}
    1752 | bool xfrm_replay_overflow_check(struct xfrm_state *x, struct sk_buff *skb);
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   net/xfrm/xfrm_replay.c:754:13: warning: 'xfrm_replay_overflow_check' defined but not used [-Wunused-function]
     754 | static bool xfrm_replay_overflow_check(struct xfrm_state *x, struct sk_buff *skb)
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/xfrm_replay_overflow_check +754 net/xfrm/xfrm_replay.c

   753	
 > 754	static bool xfrm_replay_overflow_check(struct xfrm_state *x, struct sk_buff *skb)
   755	{
   756		struct xfrm_replay_state_esn *replay_esn = x->replay_esn;
   757		__u32 oseq = replay_esn->oseq;
   758	
   759		/* We assume that this function is called with
   760		 * skb_is_gso(skb) == true
   761		 */
   762	
   763		if (x->repl_mode == XFRM_REPLAY_MODE_ESN) {
   764			if (x->type->flags & XFRM_TYPE_REPLAY_PROT) {
   765				oseq = oseq + 1 + skb_shinfo(skb)->gso_segs;
   766				if (unlikely(oseq < replay_esn->oseq))
   767					return true;
   768			}
   769		}
   770	
   771		return false;
   772	}
   773	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (167503 bytes)