netdev - Re: Re: [PATCH] net: prestera: acl: Add check for kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220930050317.32706-1-jiasheng@iscas.ac.cn>
Date:   Fri, 30 Sep 2022 13:03:17 +0800
From:   Jiasheng Jiang <jiasheng@...as.ac.cn>
To:     kuba@...nel.org
Cc:     pabeni@...hat.com, davem@...emloft.net, tchornyi@...vell.com,
        edumazet@...gle.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Jiasheng Jiang <jiasheng@...as.ac.cn>,
        Volodymyr Mytnyk <vmytnyk@...vell.com>
Subject: Re: Re: [PATCH] net: prestera: acl: Add check for kmemdup

On Fri, 30 Sep 2022 00:15:27 +0800 Jakub Kicinski wrote:
> On Wed, 28 Sep 2022 17:20:24 +0800 Jiasheng Jiang wrote:
>> As the kemdup could return NULL, it should be better to check the return
>> value and return error if fails.
>> Moreover, the return value of prestera_acl_ruleset_keymask_set() should
>> be checked by cascade.
>> 
>> Fixes: 604ba230902d ("net: prestera: flower template support")
>> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>
> 
> You must CC the authors of patch you're fixing. 
> get_maintainer will do that for you I don't understand why people can't
> simply run that script :/ You CC linux-kernel for no apparent reason
> yet you don't CC the guy who wrote the original patch.
> If you could please explain what is going on maybe we can improve the
> tooling or something.

Actually, I used get_maintainer scripts and the results is as follow:
"./scripts/get_maintainer.pl -f drivers/net/ethernet/marvell/prestera/prestera_acl.c"
Taras Chornyi <tchornyi@...vell.com> (supporter:MARVELL PRESTERA ETHERNET SWITCH DRIVER)
"David S. Miller" <davem@...emloft.net> (maintainer:NETWORKING DRIVERS)
Eric Dumazet <edumazet@...gle.com> (maintainer:NETWORKING DRIVERS)
Jakub Kicinski <kuba@...nel.org> (maintainer:NETWORKING DRIVERS)
Paolo Abeni <pabeni@...hat.com> (maintainer:NETWORKING DRIVERS)
netdev@...r.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@...r.kernel.org (open list)

Therefore, I submitted my patch to the above addresses.

And this time I checked the fixes commit, and found that it has two
authors:
Signed-off-by: Volodymyr Mytnyk <vmytnyk@...vell.com>
Signed-off-by: David S. Miller <davem@...emloft.net>

Maybe there is a problem of the script that misses one.
Anyway, I have already submitted the same patch and added
"vmytnyk@...vell.com" this time.

Thanks,
Jiang