netdev - Re: [patch net-next v2 06/13] net: make drivers to use SET_NETDEV_DEVLINK_PORT to set devlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 3 Oct 2022 09:46:38 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, pabeni@...hat.com,
        edumazet@...gle.com, tariqt@...dia.com, moshe@...dia.com,
        saeedm@...dia.com, linux-rdma@...r.kernel.org
Subject: Re: [patch net-next v2 06/13] net: make drivers to use
 SET_NETDEV_DEVLINK_PORT to set devlink_port

On Mon,  3 Oct 2022 12:51:57 +0200 Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
> 
> Benefit from the previously implemented tracking of netdev events in
> devlink code and instead of calling  devlink_port_type_eth_set() and
> devlink_port_type_clear() to set devlink port type and link to related
> netdev, use SET_NETDEV_DEVLINK_PORT() macro to assign devlink_port
> pointer to netdevice which is about to be registered.

drivers/net/ethernet/mscc/ocelot_vsc7514.c:380:23: warning: variable 'ocelot_port' set but not used [-Wunused-but-set-variable]
                struct ocelot_port *ocelot_port;
                                    ^