netdev - Re: [PATCH net-next v2 0/5] nfp: support FEC mode reporting and auto-neg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221003084111.GA39850@nj-rack01-04.nji.corigine.com>
Date:   Mon, 3 Oct 2022 16:41:11 +0800
From:   Yinjun Zhang <yinjun.zhang@...igine.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Simon Horman <simon.horman@...igine.com>,
        David Miller <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        oss-drivers@...igine.com, Fei Qin <fei.qin@...igine.com>
Subject: Re: [PATCH net-next v2 0/5] nfp: support FEC mode reporting and
 auto-neg

On Fri, Sep 30, 2022 at 06:47:35PM -0700, Jakub Kicinski wrote:
> On Thu, 29 Sep 2022 10:58:27 +0200 Simon Horman wrote:
> > this series adds support for the following features to the nfp driver:
> > 
> > * Patch 1/5: Support active FEC mode
> > * Patch 2/5: Don't halt driver on non-fatal error when interacting with fw
> > * Patch 3/5: Treat port independence as a firmware rather than port property
> > * Patch 4/5: Support link auto negotiation
> > * Patch 5/5: Support restart of link auto negotiation
> 
> Looks better, thanks for the changes.
> 
> BTW shouldn't the sp_indiff symbol be prefixed by _pf%u ?
> That's not really introduced by this series tho.

Thanks for your advice. Although sp_indiff is exposed by per-PF rtsym
_pf%u_net_app_cap, which can be used for per-PF capabilities in future,
I think sp_indiff won't be inconsistent among PFs. We'll adjust it if
it happens.