netdev - Re: [PATCH net-next v2 0/5] nfp: support FEC mode reporting and auto-neg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221003130149.07f38aaf@kernel.org>
Date:   Mon, 3 Oct 2022 13:01:49 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Yinjun Zhang <yinjun.zhang@...igine.com>
Cc:     Simon Horman <simon.horman@...igine.com>,
        David Miller <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        oss-drivers@...igine.com, Fei Qin <fei.qin@...igine.com>
Subject: Re: [PATCH net-next v2 0/5] nfp: support FEC mode reporting and
 auto-neg

On Mon, 3 Oct 2022 16:41:11 +0800 Yinjun Zhang wrote:
> > Looks better, thanks for the changes.
> > 
> > BTW shouldn't the sp_indiff symbol be prefixed by _pf%u ?
> > That's not really introduced by this series tho.  
> 
> Thanks for your advice. Although sp_indiff is exposed by per-PF rtsym
> _pf%u_net_app_cap, which can be used for per-PF capabilities in future,
> I think sp_indiff won't be inconsistent among PFs. We'll adjust it if
> it happens.

It's not about inconsistencies but about the fact that in multi-host
systems there are multiple driver instances which come and go.
The driver seems to set sp_indiff to one at load and to zero when it
unloads. IDK what that actually does to the FW but if it does anything
it's not gonna work reliably in MH.