lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 4 Oct 2022 10:04:23 +0800 From: Yinjun Zhang <yinjun.zhang@...igine.com> To: Jakub Kicinski <kuba@...nel.org> Cc: Simon Horman <simon.horman@...igine.com>, David Miller <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, oss-drivers@...igine.com, Fei Qin <fei.qin@...igine.com> Subject: Re: [PATCH net-next v2 0/5] nfp: support FEC mode reporting and auto-neg On Mon, Oct 03, 2022 at 01:01:49PM -0700, Jakub Kicinski wrote: > On Mon, 3 Oct 2022 16:41:11 +0800 Yinjun Zhang wrote: > > Thanks for your advice. Although sp_indiff is exposed by per-PF rtsym > > _pf%u_net_app_cap, which can be used for per-PF capabilities in future, > > I think sp_indiff won't be inconsistent among PFs. We'll adjust it if > > it happens. > > It's not about inconsistencies but about the fact that in multi-host > systems there are multiple driver instances which come and go. > The driver seems to set sp_indiff to one at load and to zero when it > unloads. IDK what that actually does to the FW but if it does anything > it's not gonna work reliably in MH. I see, it's indeed a problem, not only in MH case, but also in single-host-multi-PF case. Instead of renaming sp_indiff, I'll use `unload_fw_on_remove` to decide if need clean sp_indiff when unloading. I think it makes more sense. Will fix it.
Powered by blists - more mailing lists