lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 7 Oct 2022 11:32:19 -0700
From:   Jakub Kicinski <>
To:     Edward Cree <>
Cc:     Johannes Berg <>,,,,,,,,
Subject: Re: [RFC PATCH net-next 1/3] netlink: add support for formatted
 extack messages

On Fri, 7 Oct 2022 14:46:46 +0100 Edward Cree wrote:
> > That "if (__extack)" check seems a bit strange, you've long crashed with
> > a NPD if it was really NULL?  
> Good point, I blindly copied NL_SET_ERR_MSG without thinking.
> The check should enclose the whole body, will fix in v2.

FWIW you can prolly use break; thanks to the do {} while wrapping.
Maybe that's hacky.

Powered by blists - more mailing lists