netdev - Re: [RFC PATCH net-next 1/3] netlink: add support for formatted extack messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9bb2d52-c7f6-5aaa-37e5-59e7a2ff4a8e@gmail.com>
Date:   Fri, 7 Oct 2022 14:58:42 +0100
From:   Edward Cree <ecree.xilinx@...il.com>
To:     Johannes Berg <johannes@...solutions.net>, ecree@...inx.com,
        netdev@...r.kernel.org, linux-net-drivers@....com
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, habetsm.xilinx@...il.com,
        marcelo.leitner@...il.com
Subject: Re: [RFC PATCH net-next 1/3] netlink: add support for formatted
 extack messages

On 07/10/2022 14:49, Johannes Berg wrote:
> Unless maybe we printed a warning together with the full string, so the
> user could recover it?
Ooh, I like that.
Would need to net_ratelimit of course, but that should be easy enough.

It's not quite perfect as it'd evaluate the VA_ARGS twice, potentially
 side-effecting, which the original NL_SET_ERR_MSG() took some care to
 avoid, but I think we can live with that.

-ed