lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Oct 2022 10:06:03 -0400 From: Aaron Conole <aconole@...hat.com> To: Xin Long <lucien.xin@...il.com> Cc: network dev <netdev@...r.kernel.org>, dev@...nvswitch.org, Florian Westphal <fw@...len.de>, Ilya Maximets <i.maximets@....org>, Eric Dumazet <edumazet@...gle.com>, kuba@...nel.org, Paolo Abeni <pabeni@...hat.com>, davem@...emloft.net, Pablo Neira Ayuso <pablo@...filter.org> Subject: Re: [ovs-dev] [PATCH net] openvswitch: add nf_ct_is_confirmed check before assigning the helper Aaron Conole <aconole@...hat.com> writes: > Xin Long <lucien.xin@...il.com> writes: > >> A WARN_ON call trace would be triggered when 'ct(commit, alg=helper)' >> applies on a confirmed connection: >> >> WARNING: CPU: 0 PID: 1251 at net/netfilter/nf_conntrack_extend.c:98 >> RIP: 0010:nf_ct_ext_add+0x12d/0x150 [nf_conntrack] >> Call Trace: >> <TASK> >> nf_ct_helper_ext_add+0x12/0x60 [nf_conntrack] >> __nf_ct_try_assign_helper+0xc4/0x160 [nf_conntrack] >> __ovs_ct_lookup+0x72e/0x780 [openvswitch] >> ovs_ct_execute+0x1d8/0x920 [openvswitch] >> do_execute_actions+0x4e6/0xb60 [openvswitch] >> ovs_execute_actions+0x60/0x140 [openvswitch] >> ovs_packet_cmd_execute+0x2ad/0x310 [openvswitch] >> genl_family_rcv_msg_doit.isra.15+0x113/0x150 >> genl_rcv_msg+0xef/0x1f0 >> >> which can be reproduced with these OVS flows: >> >> table=0, in_port=veth1,tcp,tcp_dst=2121,ct_state=-trk >> actions=ct(commit, table=1) >> table=1, in_port=veth1,tcp,tcp_dst=2121,ct_state=+trk+new >> actions=ct(commit, alg=ftp),normal >> >> The issue was introduced by commit 248d45f1e193 ("openvswitch: Allow >> attaching helper in later commit") where it somehow removed the check >> of nf_ct_is_confirmed before asigning the helper. This patch is to fix >> it by bringing it back. >> >> Fixes: 248d45f1e193 ("openvswitch: Allow attaching helper in later commit") >> Reported-by: Pablo Neira Ayuso <pablo@...filter.org> >> Signed-off-by: Xin Long <lucien.xin@...il.com> >> --- > > Hi Xin, > > Looking at the original commit, I think this will read like a revert. I > am doing some testing now, but I think we need input from Yi-Hung to > find out what the use case is that the original fixed. I'm also not able to reproduce the WARN_ON. My env: kernel: 4c86114194e6 ("Merge tag 'iomap-6.1-merge-1' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux") Using current upstream OVS I used your flows (adjusting the port names): cookie=0x0, duration=246.240s, table=0, n_packets=17, n_bytes=1130, ct_state=-trk,tcp,in_port=v0,tp_dst=2121 actions=ct(commit,table=1) cookie=0x0, duration=246.240s, table=1, n_packets=1, n_bytes=74, ct_state=+new+trk,tcp,in_port=v0,tp_dst=2121 actions=ct(commit,alg=ftp),NORMAL and ran: $ ip netns exec server python3 -m pyftpdlib -i 172.31.110.20 & $ ip netns exec client curl ftp://172.31.110.20:2121 but no WARN_ON message got triggered. Are there additional flows you used that I am missing, or perhaps this should be on a different kernel commit? > -Aaron
Powered by blists - more mailing lists