netdev - Re: [PATCH net-next v5 1/4] devlink: Extend devlink-rate api with export functions and new params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 11 Oct 2022 15:56:51 +0200
From:   Alexander Lobakin <alexandr.lobakin@...el.com>
To:     Michal Wilczynski <michal.wilczynski@...el.com>
Cc:     Alexander Lobakin <alexandr.lobakin@...el.com>,
        kernel test robot <lkp@...el.com>, netdev@...r.kernel.org,
        kbuild-all@...ts.01.org, jacob.e.keller@...el.com,
        jesse.brandeburg@...el.com, przemyslaw.kitszel@...el.com,
        anthony.l.nguyen@...el.com, kuba@...nel.org,
        ecree.xilinx@...il.com, jiri@...nulli.us
Subject: Re: [PATCH net-next v5 1/4] devlink: Extend devlink-rate api with export functions and new params

From: kernel test robot <lkp@...el.com>
Date: Tue, 11 Oct 2022 19:32:48 +0800

> Hi Michal,
> 
> Thank you for the patch! Perhaps something to improve:
> 
> [auto build test WARNING on net-next/master]

[...]

> All warnings (new ones prefixed by >>):
> 
>    net/core/devlink.c: In function 'devl_rate_node_create':
> >> net/core/devlink.c:10314:9: warning: 'strncpy' specified bound 30 equals destination size [-Wstringop-truncation]
>    10314 |         strncpy(rate_node->name, node_name, DEVLINK_RATE_NAME_MAX_LEN);
>          |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

BTW, it's highly recommended to use strscpy().

> 
> 
> vim +/strncpy +10314 net/core/devlink.c

[...]

> -- 
> 0-DAY CI Kernel Test Service
> https://01.org/lkp

Thanks,
Olek