netdev - Re: [PATCH net-next v5 0/4] Implement devlink-rate API and extend it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <126bda05a809cb53090675725a6c5ad51d439918.camel@redhat.com>
Date:   Tue, 11 Oct 2022 15:18:54 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Michal Wilczynski <michal.wilczynski@...el.com>,
        netdev@...r.kernel.org
Cc:     alexandr.lobakin@...el.com, jacob.e.keller@...el.com,
        jesse.brandeburg@...el.com, przemyslaw.kitszel@...el.com,
        anthony.l.nguyen@...el.com, kuba@...nel.org,
        ecree.xilinx@...il.com, jiri@...nulli.us
Subject: Re: [PATCH net-next v5 0/4] Implement devlink-rate API and extend it

Hello,

On Tue, 2022-10-11 at 11:01 +0200, Michal Wilczynski wrote:
> This is a follow up on:
> https://lore.kernel.org/netdev/20220915134239.1935604-1-michal.wilczynski@intel.com/
> 
> This patch series implements devlink-rate for ice driver. Unfortunately
> current API isn't flexible enough for our use case, so there is a need to
> extend it.  Some functions have been introduced to enable the driver to
> export current Tx scheduling configuration.
> 
> In the previous submission I've made a mistake and didn't remove
> internal review comments. To avoid confusion I don't go backwards
> in my versioning and submit it as a v5.
> 
> V5:
> - removed queue support per community request
> - fix division of 64bit variable with 32bit divisor by using div_u64()
> - remove RDMA, ADQ exlusion as it's not necessary anymore
> - changed how driver exports configuration, as queues are not supported
>   anymore
> - changed IDA to Xarray for unique node identification
> 
> 
> V4:
> - changed static variable counter to per port IDA to
>   uniquely identify nodes
> 
> V3:
> - removed shift macros, since FIELD_PREP is used
> - added static_assert for struct
> - removed unnecessary functions
> - used tab instead of space in define
> 
> V2:
> - fixed Alexandr comments
> - refactored code to fix checkpatch issues
> - added mutual exclusion for RDMA, DCB
> 
> 
> 
> Michal Wilczynski (4):
>   devlink: Extend devlink-rate api with export functions and new params
>   ice: Introduce new parameters in ice_sched_node
>   ice: Implement devlink-rate API
>   ice: Prevent DCB coexistence with Custom Tx scheduler
> 
>  .../net/ethernet/intel/ice/ice_adminq_cmd.h   |   4 +-
>  drivers/net/ethernet/intel/ice/ice_common.c   |   3 +
>  drivers/net/ethernet/intel/ice/ice_dcb_lib.c  |   4 +
>  drivers/net/ethernet/intel/ice/ice_devlink.c  | 467 ++++++++++++++++++
>  drivers/net/ethernet/intel/ice/ice_devlink.h  |   2 +
>  drivers/net/ethernet/intel/ice/ice_idc.c      |   5 +
>  drivers/net/ethernet/intel/ice/ice_repr.c     |  13 +
>  drivers/net/ethernet/intel/ice/ice_sched.c    |  79 ++-
>  drivers/net/ethernet/intel/ice/ice_sched.h    |  25 +
>  drivers/net/ethernet/intel/ice/ice_type.h     |   8 +
>  .../mellanox/mlx5/core/esw/devlink_port.c     |   4 +-
>  .../net/ethernet/mellanox/mlx5/core/esw/qos.c |   4 +-
>  .../net/ethernet/mellanox/mlx5/core/esw/qos.h |   2 +-
>  drivers/net/netdevsim/dev.c                   |  10 +-
>  include/net/devlink.h                         |  21 +-
>  include/uapi/linux/devlink.h                  |   3 +
>  net/core/devlink.c                            | 145 +++++-
>  17 files changed, 767 insertions(+), 32 deletions(-)
> 
net-next is currently CLOSED,

Please repost when net-next reopens after 6.1-rc1 is cut.

Thanks,

Paolo