netdev - Re: RFH, where did I go wrong?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y0c0Yw1FjmR0m+Cs@lunn.ch>
Date:   Wed, 12 Oct 2022 23:40:51 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Thorsten Glaser <t.glaser@...ent.de>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        Dave Taht <dave.taht@...il.com>, netdev@...r.kernel.org
Subject: Re: RFH, where did I go wrong?

On Wed, Oct 12, 2022 at 10:48:53PM +0200, Thorsten Glaser wrote:
> On Wed, 12 Oct 2022, Eric Dumazet wrote:
> 
> > This looks wrong (although I have not read your code)
> > 
> > I guess RTNL is not held at this point.
> > 
> > Use kfree_skb(skb) or __qdisc_drop(skb, to_free)
> 
> Ooh! Will try! That’s what I get for getting, ahem, inspiration
> from other qdiscs.

Are other qdiscs also missing RTNL, or are you just using the
inspiration in a different context?

	    Andrew