lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20221012091947.tdiglhtzy5cvfmpe@skbuf> Date: Wed, 12 Oct 2022 12:19:47 +0300 From: Vladimir Oltean <olteanv@...il.com> To: Colin Foster <colin.foster@...advantage.com> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, Russell King <linux@...linux.org.uk>, UNGLinuxDriver@...rochip.com, Alexandre Belloni <alexandre.belloni@...tlin.com>, Claudiu Manoil <claudiu.manoil@....com>, Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>, Florian Fainelli <f.fainelli@...il.com>, Vivien Didelot <vivien.didelot@...il.com>, Andrew Lunn <andrew@...n.ch>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Rob Herring <robh+dt@...nel.org>, Lee Jones <lee@...nel.org> Subject: Re: [RFC v4 net-next 03/17] net: mscc: ocelot: expose stats layout definition to be used by other drivers On Sat, Oct 08, 2022 at 11:51:38AM -0700, Colin Foster wrote: > The ocelot_stats_layout array is common between several different chips, > some of which can only be controlled externally. Export this structure so > it doesn't have to be duplicated in these other drivers. > > Rename the structure as well, to follow the conventions of other shared > resources. > > Signed-off-by: Colin Foster <colin.foster@...advantage.com> > --- I see that ocelot->stats_layout has become a redundant indirection. It no longer contains anything hardware-specific. The register offsets are now part of the switch-specific sys_regmap. Could you please refactor the code to use a single static const struct ocelot_stats_layout in ocelot_stats.c, and remove felix->info->stats_layout and ocelot->stats_layout?
Powered by blists - more mailing lists