lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <01283d8a-3319-af3c-7139-466fe22ca8e4@digikod.net> Date: Wed, 12 Oct 2022 12:06:01 +0200 From: Mickaël Salaün <mic@...ikod.net> To: "Konstantin Meskhidze (A)" <konstantin.meskhidze@...wei.com> Cc: willemdebruijn.kernel@...il.com, gnoack3000@...il.com, linux-security-module@...r.kernel.org, netdev@...r.kernel.org, netfilter-devel@...r.kernel.org, yusongping@...wei.com, hukeping@...wei.com, anton.sirazetdinov@...wei.com Subject: Re: [PATCH v7 02/18] landlock: refactor landlock_find_rule/insert_rule On 12/10/2022 10:37, Konstantin Meskhidze (A) wrote: > > > 9/6/2022 11:07 AM, Mickaël Salaün пишет: >> Good to see such clean commit! >> >> On 29/08/2022 19:03, Konstantin Meskhidze wrote: >>> Adds a new landlock_key union and landlock_id structure to support >>> a socket port rule type. Refactors landlock_insert_rule() and >>> landlock_find_rule() to support coming network modifications. >> >>> This patch also adds is_object_pointer() and get_root() helpers. >> >> Please explain a bit what these helpers do. >> >> >>> Now adding or searching a rule in a ruleset depends on a landlock id >>> argument provided in refactored functions mentioned above. >> >> More explanation: >> A struct landlock_id identifies a unique entry in a ruleset: either a >> kernel object (e.g inode) or a typed data (e.g. TCP port). There is one >> red-black tree per key type. >> >>> >>> Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@...wei.com> >> >> Because most changes come from >> https://git.kernel.org/mic/c/8f4104b3dc59e7f110c9b83cdf034d010a2d006f >> and >> https://git.kernel.org/mic/c/7d6cf40a6f81adf607ad3cc17aaa11e256beeea4 >> you can append >> Co-developed-by: Mickaël Salaün <mic@...ikod.net> > > Do I need to add Co-developed-by: Mickaël Salaün <mic@...ikod.net> > and Signed-off-by: Mickaël Salaün <mic@...ikod.net> or just > Co-developed-by: Mickaël Salaün <mic@...ikod.net> ???? > > Cause Submiting patches article says: > https://www.kernel.org/doc/html/latest/process/submitting-patches.html > > "...Since Co-developed-by: denotes authorship, every Co-developed-by: > must be immediately followed by a Signed-off-by: of the associated > co-author...." > > Is this correct signing for this patch: > > Co-developed-by: Mickaël Salaün <mic@...ikod.net> > Signed-off-by: Mickaël Salaün <mic@...ikod.net> > Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@...wei.com> Because I'll merge your patches in my tree, I'll add my Signed-off-by to all patches. You can then just add Co-developed-by after your Signed-off-by for this one and I'll add the rest.
Powered by blists - more mailing lists