[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <69402e24-99a2-9957-693d-645b98f01cda@gmail.com>
Date: Fri, 14 Oct 2022 09:36:54 -0400
From: Sean Anderson <seanga2@...il.com>
To: Dan Carpenter <dan.carpenter@...cle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] sunhme: Uninitialized variable in happy_meal_init()
On 10/14/22 05:38, Dan Carpenter wrote:
> The "burst" string is only initialized for CONFIG_SPARC.
>
> Fixes: 24cddbc3ef11 ("sunhme: Combine continued messages")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> drivers/net/ethernet/sun/sunhme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
> index 62deed210a95..efaa6a8eadec 100644
> --- a/drivers/net/ethernet/sun/sunhme.c
> +++ b/drivers/net/ethernet/sun/sunhme.c
> @@ -1328,7 +1328,7 @@ static int happy_meal_init(struct happy_meal *hp)
> void __iomem *erxregs = hp->erxregs;
> void __iomem *bregs = hp->bigmacregs;
> void __iomem *tregs = hp->tcvregs;
> - const char *bursts;
> + const char *bursts = "";
> u32 regtmp, rxcfg;
>
> /* If auto-negotiation timer is running, kill it. */
This should be "64" to match the value used by PCI.
--Sean
Powered by blists - more mailing lists