netdev - Re: [PATCH ipsec,v2] xfrm: fix "disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221014133749.GM2602992@gauss3.secunet.de>
Date:   Fri, 14 Oct 2022 15:37:49 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Eyal Birger <eyal.birger@...il.com>
CC:     <davem@...emloft.net>, <yoshfuji@...ux-ipv6.org>,
        <dsahern@...nel.org>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <netdev@...r.kernel.org>,
        <monil191989@...il.com>, <nicolas.dichtel@...nd.com>,
        <stephen@...workplumber.org>
Subject: Re: [PATCH ipsec,v2] xfrm: fix "disable_policy" on ipv4 early demux

On Sun, Oct 09, 2022 at 10:16:43PM +0300, Eyal Birger wrote:
> The commit in the "Fixes" tag tried to avoid a case where policy check
> is ignored due to dst caching in next hops.
> 
> However, when the traffic is locally consumed, the dst may be cached
> in a local TCP or UDP socket as part of early demux. In this case the
> "disable_policy" flag is not checked as ip_route_input_noref() was only
> called before caching, and thus, packets after the initial packet in a
> flow will be dropped if not matching policies.
> 
> Fix by checking the "disable_policy" flag also when a valid dst is
> already available.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216557
> Reported-by: Monil Patel <monil191989@...il.com>
> Fixes: e6175a2ed1f1 ("xfrm: fix "disable_policy" flag use when arriving from different devices")
> Signed-off-by: Eyal Birger <eyal.birger@...il.com>

Applied, thanks Eyal!