netdev - Re: [PATCH ipsec] xfrm: lwtunnel: squelch kernel warning in case XFRM encap type is not available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221014133826.GN2602992@gauss3.secunet.de>
Date:   Fri, 14 Oct 2022 15:38:26 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Eyal Birger <eyal.birger@...il.com>
CC:     <idosch@...sch.org>, <davem@...emloft.net>, <edumazet@...gle.com>,
        <kuba@...nel.org>, <pabeni@...hat.com>,
        <herbert@...dor.apana.org.au>, <dsahern@...nel.org>,
        <contact@...elbtn.com>, <pablo@...filter.org>,
        <nicolas.dichtel@...nd.com>, <razor@...ckwall.org>,
        <daniel@...earbox.net>, <netdev@...r.kernel.org>
Subject: Re: [PATCH ipsec] xfrm: lwtunnel: squelch kernel warning in case
 XFRM encap type is not available

On Tue, Oct 11, 2022 at 11:01:37AM +0300, Eyal Birger wrote:
> Ido reported that a kernel warning [1] can be triggered from
> user space when the kernel is compiled with CONFIG_MODULES=y and
> CONFIG_XFRM=n when adding an xfrm encap type route, e.g:
> 
> $ ip route add 198.51.100.0/24 dev dummy1 encap xfrm if_id 1
> Error: lwt encapsulation type not supported.
> 
> The reason for the warning is that the LWT infrastructure has an
> autoloading feature which is meant only for encap types that don't
> use a net device,  which is not the case in xfrm encap.
> 
> Mute this warning for xfrm encap as there's no encap module to autoload
> in this case.
> 
> [1]
>  WARNING: CPU: 3 PID: 2746262 at net/core/lwtunnel.c:57 lwtunnel_valid_encap_type+0x4f/0x120
> [...]
>  Call Trace:
>   <TASK>
>   rtm_to_fib_config+0x211/0x350
>   inet_rtm_newroute+0x3a/0xa0
>   rtnetlink_rcv_msg+0x154/0x3c0
>   netlink_rcv_skb+0x49/0xf0
>   netlink_unicast+0x22f/0x350
>   netlink_sendmsg+0x208/0x440
>   ____sys_sendmsg+0x21f/0x250
>   ___sys_sendmsg+0x83/0xd0
>   __sys_sendmsg+0x54/0xa0
>   do_syscall_64+0x35/0x80
>   entry_SYSCALL_64_after_hwframe+0x63/0xcd
> 
> Reported-by: Ido Schimmel <idosch@...sch.org>
> Fixes: 2c2493b9da91 ("xfrm: lwtunnel: add lwtunnel support for xfrm interfaces in collect_md mode")
> Signed-off-by: Eyal Birger <eyal.birger@...il.com>

Applied, thanks a lot!