netdev - Re: [PATCH 1/2] thermal/drivers/iwlwifi: Use generic thermal_zone_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Oct 2022 09:38:38 +0000
From:   "Greenman, Gregory" <gregory.greenman@...el.com>
To:     "kvalo@...nel.org" <kvalo@...nel.org>,
        "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>
CC:     "Coelho, Luciano" <luciano.coelho@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "Berg, Johannes" <johannes.berg@...el.com>,
        "Errera, Nathan" <nathan.errera@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "Grumbach, Emmanuel" <emmanuel.grumbach@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Korenblit, Miriam Rachel" <miriam.rachel.korenblit@...el.com>
Subject: Re: [PATCH 1/2] thermal/drivers/iwlwifi: Use generic
 thermal_zone_get_trip() function

On Fri, 2022-10-14 at 12:21 +0200, Daniel Lezcano wrote:
> On 14/10/2022 12:15, Kalle Valo wrote:
> > Daniel Lezcano <daniel.lezcano@...aro.org> writes:
> > 
> > > The thermal framework gives the possibility to register the trip
> > > points with the thermal zone. When that is done, no get_trip_* ops are
> > > needed and they can be removed.
> > > 
> > > The get_trip_temp, get_trip_hyst and get_trip_type are handled by the
> > > get_trip_point().
> > > 
> > > The set_trip_temp() generic function does some checks which are no
> > > longer needed in the set_trip_point() ops.
> > > 
> > > Convert ops content logic into generic trip points and register them
> > > with the thermal zone.
> > > 
> > > Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> > > ---
> > >   drivers/net/wireless/intel/iwlwifi/mvm/mvm.h |  2 +-
> > >   drivers/net/wireless/intel/iwlwifi/mvm/tt.c  | 71 ++++----------------
> > >   2 files changed, 13 insertions(+), 60 deletions(-)
> > 
> > The subject should begin with "wifi: iwlwifi: ".
> > 
> > I don't see patch 2. Via which tree is the plan for this patch?
> 
> patch 2 are similar changes but related to the mellanox driver.
> 
> This is the continuation of the trip point rework:
> 
> https://lore.kernel.org/netdev/20221003092602.1323944-22-daniel.lezcano@linaro.org/t/
> 
> This patch is planned to go through the thermal tree
> 
> Sorry I should have mentioned that.
> 

As Kalle commented above, the subject should start with wifi: iwlwifi:
The commit itself seems fine to me.

Acked-by: Gregory Greenman <gregory.greenman@...el.com>