netdev - Re: [PATCH net-next 04/13] genetlink: load policy based on validation flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221019124932.39200cd7@kernel.org>
Date:   Wed, 19 Oct 2022 12:49:32 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Johannes Berg <johannes@...solutions.net>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, jiri@...nulli.us, razor@...ckwall.org,
        nicolas.dichtel@...nd.com, gnault@...hat.com,
        jacob.e.keller@...el.com, fw@...len.de
Subject: Re: [PATCH net-next 04/13] genetlink: load policy based on
 validation flags

On Wed, 19 Oct 2022 21:33:43 +0200 Johannes Berg wrote:
> > Do you mean that we no longer populate op->maxattr / op->policy and
> > some op may be reading those? I don't see any family code looking at
> > info->op.policy / maxattr.
> > 
> > First thing genl_family_rcv_msg_attrs_parse() does is:
> > 
> > 	if (!ops->maxattr)
> > 		return NULL;
> > 
> > So whether we skip it or call it - no difference.
> >   
> 
> Oh. I missed that, ok, thanks for clearing that up!

I'll put this info in the commit message, as requested.