netdev - Re: [PATCH net-next 03/13] genetlink: introduce split op representation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221019125040.07751ce8@kernel.org>
Date:   Wed, 19 Oct 2022 12:50:40 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Johannes Berg <johannes@...solutions.net>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, jiri@...nulli.us, razor@...ckwall.org,
        nicolas.dichtel@...nd.com, gnault@...hat.com,
        jacob.e.keller@...el.com, fw@...len.de, mareklindner@...mailbox.ch,
        sw@...onwunderlich.de, a@...table.cc, sven@...fation.org,
        jiri@...dia.com, nhorman@...driver.com, alex.aring@...il.com,
        stefan@...enfreihafen.org
Subject: Re: [PATCH net-next 03/13] genetlink: introduce split op
 representation

On Wed, 19 Oct 2022 21:36:00 +0200 Johannes Berg wrote:
> > It's used as an output argument here, so that's what initializes it.
> > genl_get_cmd* should always init the split command because in policy
> > dumping we don't care about the errors, we just want the structure
> > to be zeroed if do/dump is not implemented, and we'll skip accordingly.
> > Wiping the 40B just to write all the fields felt... wrong. 
> > Let KASAN catch us if we fail to init something.  
> 
> KASAN doesn't, I think, you'd need KMSAN?

Quite possibly :S  Too many SANs :S