netdev - Re: [PATCH v1 net-next 1/5] inet6: Remove inet6_destroy_sock() in sk->sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202210191754.A4tmmAp5-lkp@intel.com>
Date:   Wed, 19 Oct 2022 17:57:58 +0800
From:   kernel test robot <lkp@...el.com>
To:     Kuniyuki Iwashima <kuniyu@...zon.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        David Ahern <dsahern@...nel.org>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        Kuniyuki Iwashima <kuniyu@...zon.com>,
        Mat Martineau <mathew.j.martineau@...ux.intel.com>,
        Matthieu Baerts <matthieu.baerts@...sares.net>
Subject: Re: [PATCH v1 net-next 1/5] inet6: Remove inet6_destroy_sock() in
 sk->sk_prot->destroy().

Hi Kuniyuki,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Kuniyuki-Iwashima/inet6-Remove-inet6_destroy_sock-calls/20221019-031350
patch link:    https://lore.kernel.org/r/20221018190956.1308-2-kuniyu%40amazon.com
patch subject: [PATCH v1 net-next 1/5] inet6: Remove inet6_destroy_sock() in sk->sk_prot->destroy().
config: i386-randconfig-a001
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/90f2ccc4309ce5cc81328949d2d3f3af8f74f27a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Kuniyuki-Iwashima/inet6-Remove-inet6_destroy_sock-calls/20221019-031350
        git checkout 90f2ccc4309ce5cc81328949d2d3f3af8f74f27a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/export.h:33,
                    from include/linux/linkage.h:7,
                    from include/linux/kernel.h:17,
                    from net/mptcp/protocol.c:9:
   net/mptcp/protocol.c: In function 'mptcp_is_tcpsk':
>> net/mptcp/protocol.c:91:45: error: 'tcpv6_prot' undeclared (first use in this function); did you mean 'tcp_prot'?
      91 |         } else if (unlikely(sk->sk_prot == &tcpv6_prot)) {
         |                                             ^~~~~~~~~~
   include/linux/compiler.h:78:45: note: in definition of macro 'unlikely'
      78 | # define unlikely(x)    __builtin_expect(!!(x), 0)
         |                                             ^
   net/mptcp/protocol.c:91:45: note: each undeclared identifier is reported only once for each function it appears in
      91 |         } else if (unlikely(sk->sk_prot == &tcpv6_prot)) {
         |                                             ^~~~~~~~~~
   include/linux/compiler.h:78:45: note: in definition of macro 'unlikely'
      78 | # define unlikely(x)    __builtin_expect(!!(x), 0)
         |                                             ^


vim +91 net/mptcp/protocol.c

6f8a612a33e426 Florian Westphal 2020-11-16  75  
d2f77c53342e3e Paolo Abeni      2020-06-29  76  static bool mptcp_is_tcpsk(struct sock *sk)
0b4f33def7bbde Florian Westphal 2020-04-02  77  {
0b4f33def7bbde Florian Westphal 2020-04-02  78  	struct socket *sock = sk->sk_socket;
0b4f33def7bbde Florian Westphal 2020-04-02  79  
0b4f33def7bbde Florian Westphal 2020-04-02  80  	if (unlikely(sk->sk_prot == &tcp_prot)) {
0b4f33def7bbde Florian Westphal 2020-04-02  81  		/* we are being invoked after mptcp_accept() has
0b4f33def7bbde Florian Westphal 2020-04-02  82  		 * accepted a non-mp-capable flow: sk is a tcp_sk,
0b4f33def7bbde Florian Westphal 2020-04-02  83  		 * not an mptcp one.
0b4f33def7bbde Florian Westphal 2020-04-02  84  		 *
0b4f33def7bbde Florian Westphal 2020-04-02  85  		 * Hand the socket over to tcp so all further socket ops
0b4f33def7bbde Florian Westphal 2020-04-02  86  		 * bypass mptcp.
0b4f33def7bbde Florian Westphal 2020-04-02  87  		 */
0b4f33def7bbde Florian Westphal 2020-04-02  88  		sock->ops = &inet_stream_ops;
d2f77c53342e3e Paolo Abeni      2020-06-29  89  		return true;
0b4f33def7bbde Florian Westphal 2020-04-02  90  #if IS_ENABLED(CONFIG_MPTCP_IPV6)
0b4f33def7bbde Florian Westphal 2020-04-02 @91  	} else if (unlikely(sk->sk_prot == &tcpv6_prot)) {
0b4f33def7bbde Florian Westphal 2020-04-02  92  		sock->ops = &inet6_stream_ops;
d2f77c53342e3e Paolo Abeni      2020-06-29  93  		return true;
0b4f33def7bbde Florian Westphal 2020-04-02  94  #endif
0b4f33def7bbde Florian Westphal 2020-04-02  95  	}
0b4f33def7bbde Florian Westphal 2020-04-02  96  
d2f77c53342e3e Paolo Abeni      2020-06-29  97  	return false;
0b4f33def7bbde Florian Westphal 2020-04-02  98  }
0b4f33def7bbde Florian Westphal 2020-04-02  99  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (152506 bytes)