netdev - Re: [PATCH v4 1/3] dt-bindings: net: renesas: Document Renesas Ethernet Switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5081381c-093c-5a2b-6e17-47733a3b12e7@linaro.org>
Date:   Thu, 20 Oct 2022 08:30:28 -0400
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH v4 1/3] dt-bindings: net: renesas: Document Renesas
 Ethernet Switch

On 19/10/2022 21:31, Yoshihiro Shimoda wrote:
> Hi Krzysztof,
> 
>> From: Krzysztof Kozlowski, Sent: Wednesday, October 19, 2022 9:38 PM
>>
>> On 19/10/2022 04:35, Yoshihiro Shimoda wrote:
>>> Document Renesas Etherent Switch for R-Car S4-8 (r8a779f0).
>>>
>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
>>
>> Thank you for your patch. There is something to discuss/improve.
> 
> Thank you for your review!
> 
>>> +  ethernet-ports:
>>> +    type: object
>>> +    additionalProperties: false
>>> +
>>> +    properties:
>>> +      '#address-cells':
>>> +        description: Port number of ETHA (TSNA).
>>> +        const: 1
>>> +
>>> +      '#size-cells':
>>> +        const: 0
>>> +
>>> +    patternProperties:
>>> +      "^port@[0-9a-f]+$":
>>> +        type: object
>>> +        $ref: /schemas/net/ethernet-controller.yaml#
>>> +        unevaluatedProperties: false
>>> +
>>> +        properties:
>>> +          reg:
>>> +            description:
>>> +              Port number of ETHA (TSNA).
>>> +
>>> +          phy-handle: true
>>> +
>>> +          phy-mode: true
>>
>> Why do you need these two properties here? They are provided by
>> ethernet-controller, so I suggest to drop them.
>>
>> I already commented about it in v3.
> 
> I'm sorry. I misunderstood you comments. I thought I should drop
> "description" on these properties and "enum" on the phy-mode.
> I'll drop them on v5.

If the enum on phy-mode is different than what ethernet-controller.yaml
brings, then please keep it.

Just remove everything which is already provided by
ethernet-controller.yaml (and does not differ).

> 

Best regards,
Krzysztof