netdev - Re: [PATCH v4 2/3] net: ethernet: renesas: Add Ethernet Switch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1FXHDHxD4w7v3d1@lunn.ch>
Date:   Thu, 20 Oct 2022 16:11:40 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org,
        Vladimir Oltean <olteanv@...il.com>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v4 2/3] net: ethernet: renesas: Add Ethernet Switch driver

On Wed, Oct 19, 2022 at 07:23:26PM -0700, Florian Fainelli wrote:
> 
> 
> On 10/19/2022 1:35 AM, Yoshihiro Shimoda wrote:
> > Add Renesas Ethernet Switch driver for R-Car S4-8 to be used as an
> > ethernet controller.
> > 
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> 
> How can this be a switch driver when it does not include any switchdev
> header files nor does it attempt to be using the DSA framework? You are
> certainly duplicating a lot of things that DSA would do for you like
> managing PHYs and registering per-port nework devices. Why?

Hi Florian

It is not clear yet if this is actually a DSA switch. I asked these
questions a few revisions ago and it actually looks like it is a pure
switchdev switch. It might be possible to make it a DSA switch. It is
a bit fuzzy, since it is all internal and integrated.

  Andrew