netdev - Re: [PATCH v2 net] atlantic: fix deadlock at aq_nic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Oct 2022 18:17:12 +0200
From:   Íñigo Huguet <ihuguet@...hat.com>
To:     Igor Russkikh <irusskikh@...vell.com>
Cc:     kuba@...nel.org, andrew@...n.ch, davem@...emloft.net,
        edumazet@...gle.com, pabeni@...hat.com, mstarovo@...me,
        netdev@...r.kernel.org, Li Liang <liali@...hat.com>
Subject: Re: [PATCH v2 net] atlantic: fix deadlock at aq_nic_stop

On Thu, Oct 20, 2022 at 10:56 AM Igor Russkikh <irusskikh@...vell.com> wrote:
>
>
>
> On 10/20/2022 9:53 AM, Íñigo Huguet wrote:
> > NIC is stopped with rtnl_lock held, and during the stop it cancels the
> > 'service_task' work and free irqs.
>
> Hi Íñigo, thanks for taking care of this.
>
> Just reviewed, overall looks reasonable for me. Unfortunately I don't recall
> now why RTNL lock was used originally, most probably we've tried to secure
> parallel "ip macsec configure something" commands execution.
>
> But the model with internal mutex looks safe for me.
>
> Unfortunately I now have no ability to verify your patch, edge usecase here
> would be to try stress running in parallel:
> "ethtool -S <iface>"
> "ip macsec show"
> "ip macsec <change something>"
> Plus ideal would be link flipping.
>
> Have you tried something like that?

I will try to run that tomorrow, thanks!

>
> Reviewed-by: Igor Russkikh <irusskikh@...vell.com>
>
> Regards,
>   Igor
>


-- 
Íñigo Huguet