netdev - Re: [PATCH v3 net 0/5] amd-xgbe: Miscellaneous fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <71059a78-44df-4f92-c6ee-23ac19450f7f@amd.com>
Date:   Thu, 20 Oct 2022 12:33:49 -0500
From:   Tom Lendacky <thomas.lendacky@....com>
To:     Raju Rangoju <Raju.Rangoju@....com>, Shyam-sundar.S-k@....com,
        davem@...emloft.net, kuba@...nel.org
Cc:     netdev@...r.kernel.org, Rajesh1.Kumar@....com
Subject: Re: [PATCH v3 net 0/5] amd-xgbe: Miscellaneous fixes

On 10/20/22 01:42, Raju Rangoju wrote:
> (1) Fix the rrc for Yellow carp devices. CDR workaround path
>      is disabled for YC devices, receiver reset cycle is not
>      needed in such cases.
> 
> (2) Add enumerations for mailbox command and sub-commands.
>      Instead of using hard-coded values, use enums.
> 
> (3) Enable PLL_CTL for fixed PHY modes only. Driver does not
>      implement SW RRCM for Autoneg Off configuration, hence PLL
>      is needed for fixed PHY modes only.
> 
> (4) Fix the SFP compliance codes check for DAC cables. Some of
>      the passive cables have non-zero data at offset 6 in
>      SFP EEPROM data. So, fix the sfp compliance codes check.
> 
> (5) Add a quirk for Molex passive cables to extend the rate
>      ceiling to 0x78.
> 
> Raju Rangoju (5):
>    amd-xgbe: Yellow carp devices do not need rrc
>    amd-xgbe: use enums for mailbox cmd and sub_cmds
>    amd-xgbe: enable PLL_CTL for fixed PHY modes only
>    amd-xgbe: fix the SFP compliance codes check for DAC cables
>    amd-xgbe: add the bit rate quirk for Molex cables

For the series,

Acked-by: Tom Lendacky <thomas.lendacky@....com>

> 
>   drivers/net/ethernet/amd/xgbe/xgbe-pci.c    |  5 ++
>   drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 58 +++++++++++++--------
>   drivers/net/ethernet/amd/xgbe/xgbe.h        | 26 +++++++++
>   3 files changed, 68 insertions(+), 21 deletions(-)
>