netdev - Re: [PATCH v3 net 1/5] amd-xgbe: Yellow carp devices do not need rrc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221020214615.767a8c35@kernel.org>
Date:   Thu, 20 Oct 2022 21:46:15 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Raju Rangoju <Raju.Rangoju@....com>
Cc:     <thomas.lendacky@....com>, <Shyam-sundar.S-k@....com>,
        <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <Rajesh1.Kumar@....com>
Subject: Re: [PATCH v3 net 1/5] amd-xgbe: Yellow carp devices do not need
 rrc

On Thu, 20 Oct 2022 12:12:11 +0530 Raju Rangoju wrote:
> Link stability issues are noticed on Yellow carp platforms when Receiver
> Reset Cycle is issued. Since the CDR workaround is disabled on these
> platforms, the Receiver Reset Cycle is not needed.
> 
> So, avoid issuing rrc on Yellow carp platforms.

Let me retry [1] the same question:

These devices are only present on SoCs? Changing global data during
probe looks odd.

[1] https://lore.kernel.org/all/20221006172654.45372b3b@kernel.org/