netdev - Re: [PATCH v3 net 1/5] amd-xgbe: Yellow carp devices do not need rrc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1cdda523-fcab-be4d-42d3-8ea7dd4a2e2a@amd.com>
Date:   Fri, 21 Oct 2022 08:40:16 -0500
From:   Tom Lendacky <thomas.lendacky@....com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Raju Rangoju <Raju.Rangoju@....com>
Cc:     Shyam-sundar.S-k@....com, davem@...emloft.net,
        netdev@...r.kernel.org, Rajesh1.Kumar@....com
Subject: Re: [PATCH v3 net 1/5] amd-xgbe: Yellow carp devices do not need rrc

On 10/20/22 23:46, Jakub Kicinski wrote:
> On Thu, 20 Oct 2022 12:12:11 +0530 Raju Rangoju wrote:
>> Link stability issues are noticed on Yellow carp platforms when Receiver
>> Reset Cycle is issued. Since the CDR workaround is disabled on these
>> platforms, the Receiver Reset Cycle is not needed.
>>
>> So, avoid issuing rrc on Yellow carp platforms.
> 
> Let me retry [1] the same question:
> 
> These devices are only present on SoCs? Changing global data during
> probe looks odd.

I can answer for Raju, yes, these are only on SoCs.

But it would still probably be worth a series that allocates memory to 
copy the vdata and use that, free to modify without impacting any other 
device that is probed.

Thanks,
Tom

> 
> [1] https://lore.kernel.org/all/20221006172654.45372b3b@kernel.org/