netdev - Re: [PATCH v6 01/23] net: Introduce direct data placement tcp offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Oct 2022 22:05:40 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Aurelien Aptel <aaptel@...dia.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com, saeedm@...dia.com, tariqt@...dia.com,
        linux-nvme@...ts.infradead.org, sagi@...mberg.me, hch@....de,
        kbusch@...nel.org, axboe@...com, chaitanyak@...dia.com,
        smalin@...dia.com, ogerlitz@...dia.com, yorayz@...dia.com,
        borisp@...dia.com, aurelien.aptel@...il.com, malin1024@...il.com
Subject: Re: [PATCH v6 01/23] net: Introduce direct data placement tcp
 offload

On Thu, 20 Oct 2022 13:18:16 +0300 Aurelien Aptel wrote:
> +#ifdef CONFIG_ULP_DDP
> +	__u8                    ulp_ddp:1;
> +	__u8			ulp_crc:1;
> +#define IS_ULP_DDP(skb) ((skb)->ulp_ddp)
> +#define IS_ULP_CRC(skb) ((skb)->ulp_crc)
> +#else
> +#define IS_ULP_DDP(skb) (0)
> +#define IS_ULP_CRC(skb) (0)
> +#endif

This spews 10000 sparse warnings. I think it may be because of 
the struct_group() magic. Try moving the macros outside of the struct
definition. And make it a static inline while at it, dunno why you used
a define in the first place :S

Please don't repost before Monday just for that, maybe someone will find
time to review over the weekend...