netdev - Re: [PATCH v6 01/23] net: Introduce direct data placement tcp offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <253y1t9v2y8.fsf@mtr-vdi-124.i-did-not-set--mail-host-address--so-tickle-me>
Date:   Fri, 21 Oct 2022 14:19:43 +0300
From:   Aurelien Aptel <aaptel@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com, saeedm@...dia.com, tariqt@...dia.com,
        linux-nvme@...ts.infradead.org, sagi@...mberg.me, hch@....de,
        kbusch@...nel.org, axboe@...com, chaitanyak@...dia.com,
        smalin@...dia.com, ogerlitz@...dia.com, yorayz@...dia.com,
        borisp@...dia.com, aurelien.aptel@...il.com, malin1024@...il.com
Subject: Re: [PATCH v6 01/23] net: Introduce direct data placement tcp offload

Hi Jakub,

Thanks for looking at this.

Jakub Kicinski <kuba@...nel.org> writes:
> This spews 10000 sparse warnings. I think it may be because of
> the struct_group() magic. Try moving the macros outside of the struct
> definition. And make it a static inline while at it, dunno why you used
> a define in the first place :S

Sure, we will update it.

> Please don't repost before Monday just for that, maybe someone will find
> time to review over the weekend...

Ok

Thanks,