netdev - Re: [PATCH net 2/2] kcm: annotate data-races around kcm->rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 22 Oct 2022 19:46:28 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        eric.dumazet@...il.com, syzbot <syzkaller@...glegroups.com>
Subject: Re: [PATCH net 2/2] kcm: annotate data-races around kcm->rx_wait

On Thu, Oct 20, 2022 at 10:45:12PM +0000, Eric Dumazet wrote:
> kcm->rx_psock can be read locklessly in kcm_rfree().

Copy-n-paste typo here.

> Annotate the read and writes accordingly.

I wonder why not simply acquire mux->rx_lock earlier?

Thanks.