netdev - Re: [PATCH net] net: sched: cbq: stop timer in cbq_destroy() when cbq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1Ss3OaWuWR5p2A3@pop-os.localdomain>
Date:   Sat, 22 Oct 2022 19:54:20 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Zhengchao Shao <shaozhengchao@...wei.com>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, jiri@...nulli.us,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, kaber@...sh.net, weiyongjun1@...wei.com,
        yuehaibing@...wei.com
Subject: Re: [PATCH net] net: sched: cbq: stop timer in cbq_destroy() when
 cbq_init() fails

On Sat, Oct 22, 2022 at 06:40:54PM +0800, Zhengchao Shao wrote:
> When qdisc_create() fails to invoke the cbq_init() function for
> initialization, the timer has been started. But cbq_destroy() doesn't
> stop the timer. Fix it.
> 

Hmm? qdisc_watchdog_init() only initializes it, not starts it, right?

Thanks.