netdev - Re: [PATCH net] net: sched: cbq: stop timer in cbq_destroy() when cbq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7b4472d-013a-2999-7ea5-623af852ed3b@huawei.com>
Date:   Mon, 24 Oct 2022 18:53:30 +0800
From:   shaozhengchao <shaozhengchao@...wei.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
CC:     <netdev@...r.kernel.org>, <jhs@...atatu.com>, <jiri@...nulli.us>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <kaber@...sh.net>, <weiyongjun1@...wei.com>,
        <yuehaibing@...wei.com>
Subject: Re: [PATCH net] net: sched: cbq: stop timer in cbq_destroy() when
 cbq_init() fails



On 2022/10/23 10:54, Cong Wang wrote:
> On Sat, Oct 22, 2022 at 06:40:54PM +0800, Zhengchao Shao wrote:
>> When qdisc_create() fails to invoke the cbq_init() function for
>> initialization, the timer has been started. But cbq_destroy() doesn't
>> stop the timer. Fix it.
>>
> 
> Hmm? qdisc_watchdog_init() only initializes it, not starts it, right?
> 
> Thanks.
Hi Wang:
	Thank you for your review. The description is incorrect,
qdisc_watchdog_init() only initializes timer, and cbq_destroy() missed
to cancle timer.

Zhengchao Shao