netdev - Re: [PATCH net] i40e: Fix ethtool rx-flow-hash setting for X722

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1VuCYixOEqWgBdc@unreal>
Date:   Sun, 23 Oct 2022 19:38:33 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Jacob Keller <jacob.e.keller@...el.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        Slawomir Laba <slawomirx.laba@...el.com>,
        Michal Jaron <michalx.jaron@...el.com>,
        Mateusz Palczewski <mateusz.palczewski@...el.com>,
        Gurucharan <gurucharanx.g@...el.com>
Subject: Re: [PATCH net] i40e: Fix ethtool rx-flow-hash setting for X722

On Fri, Oct 21, 2022 at 02:38:19PM -0700, Jacob Keller wrote:
> From: Slawomir Laba <slawomirx.laba@...el.com>
> 
> When enabling flow type for RSS hash via ethtool:
> 
> ethtool -N $pf rx-flow-hash tcp4|tcp6|udp4|udp6 s|d
> 
> the driver would fail to setup this setting on X722
> device since it was using the mask on the register
> dedicated for X710 devices.
> 
> Apply a different mask on the register when setting the
> RSS hash for the X722 device.
> 
> When displaying the flow types enabled via ethtool:
> 
> ethtool -n $pf rx-flow-hash tcp4|tcp6|udp4|udp6
> 
> the driver would print wrong values for X722 device.
> 
> Fix this issue by testing masks for X722 device in
> i40e_get_rss_hash_opts function.
> 
> Fixes: eb0dd6e4a3b3 ("i40e: Allow RSS Hash set with less than four parameters")
> Signed-off-by: Slawomir Laba <slawomirx.laba@...el.com>
> Signed-off-by: Michal Jaron <michalx.jaron@...el.com>
> Signed-off-by: Mateusz Palczewski <mateusz.palczewski@...el.com>
> Tested-by: Gurucharan <gurucharanx.g@...el.com> (A Contingent worker at Intel)
> ---

Jacob,

I don't see your SOB here.

Thanks