netdev - RE: [PATCH net] i40e: Fix ethtool rx-flow-hash setting for X722

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SA2PR11MB5100DF495182B7328D763913D62E9@SA2PR11MB5100.namprd11.prod.outlook.com>
Date:   Mon, 24 Oct 2022 09:56:14 +0000
From:   "Keller, Jacob E" <jacob.e.keller@...el.com>
To:     Leon Romanovsky <leon@...nel.org>
CC:     Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Laba, SlawomirX" <slawomirx.laba@...el.com>,
        "Jaron, MichalX" <michalx.jaron@...el.com>,
        "Palczewski, Mateusz" <mateusz.palczewski@...el.com>,
        "G, GurucharanX" <gurucharanx.g@...el.com>
Subject: RE: [PATCH net] i40e: Fix ethtool rx-flow-hash setting for X722



> -----Original Message-----
> From: Leon Romanovsky <leon@...nel.org>
> Sent: Sunday, October 23, 2022 9:39 AM
> To: Keller, Jacob E <jacob.e.keller@...el.com>
> Cc: Jakub Kicinski <kuba@...nel.org>; David Miller <davem@...emloft.net>;
> netdev@...r.kernel.org; Laba, SlawomirX <slawomirx.laba@...el.com>; Jaron,
> MichalX <michalx.jaron@...el.com>; Palczewski, Mateusz
> <mateusz.palczewski@...el.com>; G, GurucharanX <gurucharanx.g@...el.com>
> Subject: Re: [PATCH net] i40e: Fix ethtool rx-flow-hash setting for X722
> 
> On Fri, Oct 21, 2022 at 02:38:19PM -0700, Jacob Keller wrote:
> > From: Slawomir Laba <slawomirx.laba@...el.com>
> >
> > When enabling flow type for RSS hash via ethtool:
> >
> > ethtool -N $pf rx-flow-hash tcp4|tcp6|udp4|udp6 s|d
> >
> > the driver would fail to setup this setting on X722
> > device since it was using the mask on the register
> > dedicated for X710 devices.
> >
> > Apply a different mask on the register when setting the
> > RSS hash for the X722 device.
> >
> > When displaying the flow types enabled via ethtool:
> >
> > ethtool -n $pf rx-flow-hash tcp4|tcp6|udp4|udp6
> >
> > the driver would print wrong values for X722 device.
> >
> > Fix this issue by testing masks for X722 device in
> > i40e_get_rss_hash_opts function.
> >
> > Fixes: eb0dd6e4a3b3 ("i40e: Allow RSS Hash set with less than four
> parameters")
> > Signed-off-by: Slawomir Laba <slawomirx.laba@...el.com>
> > Signed-off-by: Michal Jaron <michalx.jaron@...el.com>
> > Signed-off-by: Mateusz Palczewski <mateusz.palczewski@...el.com>
> > Tested-by: Gurucharan <gurucharanx.g@...el.com> (A Contingent worker at
> Intel)
> > ---
> 
> Jacob,
> 
> I don't see your SOB here.
> 
> Thanks

Oops, yep I forgot to add it. I think I need to resend this anyways due to a conflict. Will make a v2.

Thanks,
Jake