netdev - Re: [PATCH net] net: fix UAF issue in nfqnl_nf_hook_drop() when ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166661221488.6085.16932100870985132190.git-patchwork-notify@kernel.org>
Date:   Mon, 24 Oct 2022 11:50:14 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     shaozhengchao <shaozhengchao@...wei.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, shakeelb@...gle.com,
        roman.gushchin@...ux.dev, hmukos@...dex-team.ru, memxor@...il.com,
        vasily.averin@...ux.dev, ebiederm@...ssion.com,
        weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH net] net: fix UAF issue in nfqnl_nf_hook_drop() when
 ops_init() failed

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@...emloft.net>:

On Thu, 20 Oct 2022 10:42:13 +0800 you wrote:
> When the ops_init() interface is invoked to initialize the net, but
> ops->init() fails, data is released. However, the ptr pointer in
> net->gen is invalid. In this case, when nfqnl_nf_hook_drop() is invoked
> to release the net, invalid address access occurs.
> 
> The process is as follows:
> setup_net()
> 	ops_init()
> 		data = kzalloc(...)   ---> alloc "data"
> 		net_assign_generic()  ---> assign "date" to ptr in net->gen
> 		...
> 		ops->init()           ---> failed
> 		...
> 		kfree(data);          ---> ptr in net->gen is invalid
> 	...
> 	ops_exit_list()
> 		...
> 		nfqnl_nf_hook_drop()
> 			*q = nfnl_queue_pernet(net) ---> q is invalid
> 
> [...]

Here is the summary with links:
  - [net] net: fix UAF issue in nfqnl_nf_hook_drop() when ops_init() failed
    https://git.kernel.org/netdev/net/c/d266935ac43d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html